False positives for match() in OperatorSpacingSniff#3653
Merged
gsherwood merged 1 commit intosquizlabs:masterfrom Sep 10, 2022
Merged
False positives for match() in OperatorSpacingSniff#3653gsherwood merged 1 commit intosquizlabs:masterfrom
match() in OperatorSpacingSniff#3653gsherwood merged 1 commit intosquizlabs:masterfrom
Conversation
jrfnl
requested changes
Aug 24, 2022
Contributor
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Nice catch! Just one remark.
jrfnl
reviewed
Aug 24, 2022
kukulich
force-pushed
the
operator-spacing
branch
from
5318e17 to
c0a8bb7
Compare
gsherwood
changed the title
match() in OperatorSpacingSniffmatch() in OperatorSpacingSniff
Member
|
Thanks for fixing this. I found a similar error in Squiz.Formatting.OperatorBracket as a result. |
Contributor
|
Nice! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.